-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare for 3.4.6 #449
Prepare for 3.4.6 #449
Conversation
CHANGELOG.md
Outdated
@@ -15,6 +15,10 @@ This project adheres to [Semantic Versioning](http://semver.org/). | |||
#### Fixed | |||
- nothing yet | |||
|
|||
## [3.4.6](https://github.com/Iterable/iterable-android-sdk/releases/tag/3.4.6) | |||
#### Fixed | |||
- Fixed an issue where configurations would not be loaded. `config` in `IterableApi` accessed through sharedInstance. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this in master already? I don't see this change in the master commits.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ohh my.. its not in master yet!
Codecov Report
@@ Coverage Diff @@
## master #449 +/- ##
==========================================
- Coverage 63.30% 63.25% -0.06%
==========================================
Files 66 66
Lines 3908 3908
Branches 457 457
==========================================
- Hits 2474 2472 -2
- Misses 1185 1188 +3
+ Partials 249 248 -1
Continue to review full report at Codecov.
|
aeacad7
to
8d27f1a
Compare
8d27f1a
to
5f81366
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LFTM
🔹 Jira Ticket(s) if any
✏️ Description
Prepare for 3.4.6