Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for 3.4.6 #449

Merged
merged 1 commit into from
Jun 1, 2022
Merged

Prepare for 3.4.6 #449

merged 1 commit into from
Jun 1, 2022

Conversation

Ayyanchira
Copy link
Member

🔹 Jira Ticket(s) if any

✏️ Description

Prepare for 3.4.6

@Ayyanchira Ayyanchira requested a review from vbabenkoru May 27, 2022 20:18
CHANGELOG.md Outdated
@@ -15,6 +15,10 @@ This project adheres to [Semantic Versioning](http://semver.org/).
#### Fixed
- nothing yet

## [3.4.6](https://github.com/Iterable/iterable-android-sdk/releases/tag/3.4.6)
#### Fixed
- Fixed an issue where configurations would not be loaded. `config` in `IterableApi` accessed through sharedInstance.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this in master already? I don't see this change in the master commits.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ohh my.. its not in master yet!

@codecov
Copy link

codecov bot commented May 27, 2022

Codecov Report

Merging #449 (0fcde4f) into master (ad081e7) will decrease coverage by 0.05%.
The diff coverage is n/a.

❗ Current head 0fcde4f differs from pull request most recent head 5f81366. Consider uploading reports for the commit 5f81366 to get more accurate results

@@            Coverage Diff             @@
##           master     #449      +/-   ##
==========================================
- Coverage   63.30%   63.25%   -0.06%     
==========================================
  Files          66       66              
  Lines        3908     3908              
  Branches      457      457              
==========================================
- Hits         2474     2472       -2     
- Misses       1185     1188       +3     
+ Partials      249      248       -1     
Impacted Files Coverage Δ
...in/java/com/iterable/iterableapi/IterableUtil.java 62.50% <0.00%> (-5.00%) ⬇️
.../com/iterable/iterableapi/IterableRequestTask.java 81.22% <0.00%> (+1.74%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ebcb25b...5f81366. Read the comment docs.

@Ayyanchira Ayyanchira force-pushed the MOB-4463-Release-3.4.6 branch from aeacad7 to 8d27f1a Compare May 27, 2022 20:31
@Ayyanchira Ayyanchira force-pushed the MOB-4463-Release-3.4.6 branch from 8d27f1a to 5f81366 Compare May 27, 2022 20:32
Copy link
Contributor

@davidtruong davidtruong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LFTM

@Ayyanchira Ayyanchira merged commit 15f3951 into master Jun 1, 2022
@Ayyanchira Ayyanchira deleted the MOB-4463-Release-3.4.6 branch June 1, 2022 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants