Feature/feat 1307 reload config on file change #1325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oring the event names to all be kebab-case, instead of a mix of camelCase and kebab-case. adding watchConfigFile option to watch the config file and restart the app if it changes, and other small refactoring
…nto feature/feat-1307-reload-config-on-file-change
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add watchConfigFile option to restart the app if the configuration changes.
Modify configError message to have an icon and adding the ability to provide warning dialogs (for config deprecation)
warning dialog example
error dialog example
Refactoring around inTune and the config file handling
Refactoring events to all be kebab-case instead of a mix of kebab-case and camelCase
Closes #1307 and #1326