Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

@mentions to work with video/edge #10

Closed
IsmaelMartinez opened this issue Oct 30, 2018 · 1 comment
Closed

@mentions to work with video/edge #10

IsmaelMartinez opened this issue Oct 30, 2018 · 1 comment
Assignees
@IsmaelMartinez
Labels
enhancement New feature or request
Milestone
0.1.8

Comments

@IsmaelMartinez
Copy link
Owner

Mentions only work with chrome userAgent. Unfortunately you need edge as userAgent to be able to have video calls.

The following issue number 8 from JamieMagee repository, indicates that it is possible to have it both working together.

I believe I have seen it temporarily working what it will mean it could be a difference between electron 3 and 1.8 (probably also 2).

Any work related to this, will be added to this thread.
@IsmaelMartinez IsmaelMartinez added the enhancement New feature or request label Oct 30, 2018
@IsmaelMartinez IsmaelMartinez self-assigned this Oct 30, 2018
@IsmaelMartinez IsmaelMartinez added this to the 0.1.8 milestone Oct 30, 2018
IsmaelMartinez added a commit that referenced this issue Oct 31, 2018
@IsmaelMartinez
Fixing issue #10. Removing the ability to select the user agent as it…
dacb13f 
… is not necessary anymore
@IsmaelMartinez IsmaelMartinez mentioned this issue Nov 1, 2018
Merged
IsmaelMartinez added a commit that referenced this issue Nov 1, 2018
@IsmaelMartinez
Updated README.md
99621c5 
Removing mentions and video call from the known issues as they should have been fixed as part of version 0.1.8 (#10 )
@IsmaelMartinez IsmaelMartinez mentioned this issue Nov 1, 2018
Open
@IsmaelMartinez
Copy link
Owner Author

This was a timing issue and a edge userAgent string issue. Fixed both and now it seems to be all working fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@IsmaelMartinez IsmaelMartinez

Labels
enhancement New feature or request
Projects
None yet
Milestone
0.1.8
Development

No branches or pull requests
1 participant
@IsmaelMartinez