Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update and clarify README for 7.x #101

Merged
merged 1 commit into from
Oct 22, 2019
Merged

Update and clarify README for 7.x #101

merged 1 commit into from
Oct 22, 2019

Conversation

bencomp
Copy link

@bencomp bencomp commented Aug 21, 2019

JIRA Ticket: n/a

Related PR for release branch: #100

What does this Pull Request do?

This update does not present new information, but hopefully makes the README more accessible.

  • add "Djatoka or IIIF image server" as requirement
  • reorder installation options, implicitly prefer Drush
  • explain what configuration is discussed here
  • explain IIIF settings
  • align IIIF settings with Djatoka settings
  • make reverse proxy information more generic
  • remove Apache example setup
  • update Cantaloupe URLs
  • use more informative link labels
  • fix a few typos

What's new?

Of the above listed changes, I consider these new-ish:

  • add "Djatoka or IIIF image server" as requirement
  • explain what configuration is discussed here
  • explain IIIF settings
  • align IIIF settings with Djatoka settings
  • make reverse proxy information more generic
  • remove Apache example setup
  • update Cantaloupe URLs
  • use more informative link labels

How should this be tested?

Please read.

Additional Notes:

I haven't touched the wiki page yet.

Interested parties

@DiegoPino, @DonRichards and @Islandora/7-x-1-x-committers

This update does not present new information, but hopefully makes the
README more readable.

- add "Djatoka or IIIF image server" as requirement
- reorder installation options, implicitly prefer Drush
- explain what configuration is discussed here
- explain IIIF settings
- align IIIF settings with Djatoka settings
- make reverse proxy information more generic
- remove Apache example setup
- update Cantaloupe URLs
- use more informative link labels
- fix a few typos
@manez
Copy link
Member

manez commented Oct 18, 2019

The updates make sense to me. @DiegoPino @DonRichards any objections to a merge when the clock runs out?

@manez
Copy link
Member

manez commented Oct 22, 2019

Clock has run four times, so... I guess this goes in!

@manez manez merged commit 8f4fac7 into Islandora:7.x Oct 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants