Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save mirador instances in the DOM #47

Merged
merged 6 commits into from
Jul 18, 2024
Merged

Save mirador instances in the DOM #47

merged 6 commits into from
Jul 18, 2024

Conversation

joecorall
Copy link
Member

What does this Pull Request do?

Save mirador instance in drupalSettings so other modules can use mirador's store/dispatch.

  • Related GitHub Issue: (link)

  • Other Relevant Links: (Google Groups discussion, related pull requests,
    Release pull requests, etc.)

What's new?

A in-depth description of the changes made by this PR. Technical details and
possible side effects.

  • Changes x feature to such that y
  • Added x
  • Removed y
  • Does this change add any new dependencies?
  • Does this change require any other modifications to be made to the repository
    (i.e. Regeneration activity, etc.)?
  • Could this change impact execution of existing code?

How should this be tested?

A description of what steps someone could take to:

  • Reproduce the problem you are fixing (if applicable)
  • Test that the Pull Request does what is intended.
  • Please be as detailed as possible.
  • Good testing instructions help get your PR completed faster.

Documentation Status

  • Does this change existing behaviour that's currently documented?
  • Does this change require new pages or sections of documentation?
  • Who does this need to be documented for?
  • Associated documentation pull request(s): ___ or documentation issue ___

Additional Notes:

Any additional information that you think would be helpful when reviewing this
PR.

Interested parties

Tag (@ mention) interested parties or, if unsure, @Islandora/committers

js/mirador_viewer.js Outdated Show resolved Hide resolved
js/mirador_viewer.js Outdated Show resolved Hide resolved
js/mirador_viewer.js Outdated Show resolved Hide resolved
js/mirador_viewer.js Outdated Show resolved Hide resolved
js/mirador_viewer.js Outdated Show resolved Hide resolved
@joecorall joecorall changed the title Save mirador instance in drupalSettings Save mirador instances in the DOM Jun 26, 2024
js/mirador_viewer.js Outdated Show resolved Hide resolved
@seth-shaw-asu seth-shaw-asu requested a review from alxp July 3, 2024 17:26
@alxp
Copy link
Contributor

alxp commented Jul 7, 2024

What am I missing here?

image

Not seeing the instances. (I'm not logged in if that makes a difference.)

@adam-vessey
Copy link
Contributor

Just grabbed it locally here, applied patch-wise, cleared cache, and it seems to be there?:
Screenshot 2024-07-10 at 14 30 19

@alxp alxp merged commit c6051ef into 2.x Jul 18, 2024
@joecorall joecorall deleted the save-instance branch July 19, 2024 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants