Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add media save redirect. #971

Merged
merged 3 commits into from
Sep 25, 2023
Merged

Add media save redirect. #971

merged 3 commits into from
Sep 25, 2023

Conversation

rosiel
Copy link
Member

@rosiel rosiel commented Aug 8, 2023

GitHub Issue: LEAF-VRE/islandora-UX-useathon#3

What does this Pull Request do?

Redirects you to the node page after creating a media from "Add Media".

What's new?

  • Adds a redirect
  • Does this change add any new dependencies? no
  • Does this change require any other modifications to be made to the repository
    (i.e. Regeneration activity, etc.)? no
  • Could this change impact execution of existing code? no

How should this be tested?

Create a node and create an attached media. Without this PR, you land at the global media view.
With this PR, you land on a node.
It should also not break when you create a media that is not a member of a node.
This applies only to the creation of new media

Documentation Status

Additional Notes:

Any additional information that you think would be helpful when reviewing this
PR.

Interested parties

Tag (@ mention) interested parties or, if unsure, @Islandora/committers

@rosiel
Copy link
Member Author

rosiel commented Aug 10, 2023

Discussion from the Tech call was that this would break existing redirects.
Closing as un-resolveable.

@rosiel rosiel closed this Aug 10, 2023
@rosiel rosiel deleted the media-redirect branch August 10, 2023 16:23
@adam-vessey
Copy link

Discussion from the Tech call was that this would break existing redirects. Closing as un-resolveable.

I thought a toggle was going to be introduced around it?

Could go so far as to have it default to "on" for new installations (as in, "true" in whatever config object under config/install), but with an update hook to set it as "off" in existing installations.

@rosiel rosiel restored the media-redirect branch August 11, 2023 16:58
@rosiel rosiel reopened this Aug 11, 2023
@rosiel
Copy link
Member Author

rosiel commented Aug 11, 2023

I thought a toggle was going to be introduced around it?

Toggle implemented.

Could go so far as to have it default to "on" for new installations (as in, "true" in whatever config object under config/install), but with an update hook to set it as "off" in existing installations.

Also implemented.

@ysuarez
Copy link

ysuarez commented Aug 16, 2023

I am going to try to review this. Seth thought that it may not matter if I use a site with isntall_profile versus starter site. Not sure which one I will use.

I will try to put in a patch of this change tot eh islandora module, hit drush updb, then clear cache then test it.

@ysuarez ysuarez self-requested a review August 16, 2023 17:18
Copy link

@aOelschlager aOelschlager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works!

@aOelschlager aOelschlager merged commit e2ec673 into Islandora:2.x Sep 25, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants