forked from alxp/islandora
-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include islandora_fits into islandora/modules #907
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change Package from Custom to Islandora
Remove perms
... also, identify the term by URI instead of by name, as it's the URI that is used to related to it from config.
... also, got lost in touching up formatting of things.
…n-and-id Term installation and reporting
…uring-sync Drop unnecessary config manipulation
Don't appear to be able to comment on it directly, but |
adam-vessey
reviewed
Nov 9, 2022
Closing as the composer requirements exceed what you might need with an islandora. Instead, I'll see about transferring the repo to the Foundation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue: #906
What does this Pull Request do?
Includes Islandora Fits as a submodule of Islandora.
What's new?
Islandora Fits submodule, including its git history.
Added a dependency to
composer.json
for ext-simpleXML, required by Islandora FITS so it can parse XML.Does this change add any new dependencies? - yes, simpleXML. will be installed automatically when using Composer to update islandora.
Does this change require any other modifications to be made to the repository
(i.e. Regeneration activity, etc.)?
Could this change impact execution of existing code? no, shouldn't.
How should this be tested?
To upgrade to this version:
composer remove "islandora-rdm/islandora_fits"
composer update -W "islandora/islandora"
(make sure you get the new code)islandora_fits_tags
migration with the islandora tags migration. I'm not sure we should, since this is an optional module. But i'm open to suggestions.Documentation Status
Deployment Status (post-commit)
Additional Notes:
Any additional information that you think would be helpful when reviewing this
PR.
Interested parties
Tag (@ mention) interested parties or, if unsure, @Islandora/committers