Adds suggestion for drupal/transliterate_filenames #761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dannylamb
changed the title
|
This looks good. The module itself is relatively simple and could probably be used as a template for an alternate version if a repository wants more control over renaming. That said, could we not include in |
|
I'm fine with that. Keep it in the composer.json but enable using Ansible. |
dannylamb
changed the title
seth-shaw-unlv
approved these changes
Feb 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA Ticket: Resolves Islandora/documentation#1309 and Islandora/documentation#1366
What does this Pull Request do?
Pulls in
drupal/transliterate_filenamesto sanitize file names on upload.What's new?
A new dependency, that's it. Requires no config or special installation steps.
Interested parties
@Islandora/8-x-committers