Add submodules to CI testing #749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whikloj
reviewed
Dec 18, 2019
whikloj
requested changes
Dec 18, 2019
|
Having just diagnosed the errors for islandora_video, it looks like all the failures from the new modules are related to schema errors. I can fix it pretty easily. |
|
@dannylamb you doing that here? Also there is a coder_sniffer error. |
|
Ima doin' it. I can put it here or with the other PR I have that fixes tests. |
|
I merged #747, if that's the one you mean. |
|
@whikloj You sir are both a 🤵♂️ and a 👨🏫 |
|
Gonna have a long wait for Travis here, but I think I got it. |
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Github issue: Islandora/documentation#1390
What does this Pull Request do?
Adds all the submodules to CI testing with Travis. We were only running the breadcrumbs submodule before.
What's new?
Testing, and fixes to make the tests work.
How should this be tested?
Confirm that Travis has been appeased.
Interested parties
@Islandora/8-x-committers