Add 'Original Name' field storage

[seth-shaw-unlv]

Github Issue: Islandora/documentation#1276

What does this Pull Request do?

Adds the PREMIS 3 namespace and creates the field storage for an 'original name' field for media.

How should this be tested?

• Apply this PR
• Apply Add 'Original Name' field to Media islandora_defaults#13
• Import both the Islandora Core and Islandora Defaults features. E.g. drush fim -y islandora_core_feature; drush fim -y islandora_defaults
• Create a Media; you should see an 'Original Name' field. Plop any text you want in there.
• View the Media's JSON-LD; you should see the text from the original name field associated with the PREMIS 3 originalName predicate
• View the Media in Fedora; the PREMIS 3 originalName value should be there too.

Additional Notes:

We should eventually figure out how to auto-populate this from the file upload widget.

Interested parties

@mjordan, @Islandora/8-x-committers

[mjordan]

@seth-shaw-unlv Travis is failing with a "No such feature is installed: islandora_core_feature" error. Can you take a look?

[seth-shaw-unlv]

@mjordan, I neglected to remove the field_permissions dependency Features included. It should build now.

[mjordan]

Cool, I'll re-pull so I can test on the plane 😄

[mjordan]

Still failing, this time on what appears to be a crayfish dependency issue.

[seth-shaw-unlv]

@mjordan, yeah, we've been chatting about that on Slack. It needed a PR that is now merged. Should be ready to rebuild now. 🤞

[mjordan]

Getting the following when I try to import the features. I'm in the issue-1276 branch on both the islandora and islandora_defaults modules:

vagrant@claw:/var/www/html/drupal/web/modules$ drush fim islandora
vagrant@claw:/var/www/html/drupal/web/modules$ drush fim islandora_defaults

 Do you really want to import islandora_defaults : field.field.media.video.field_original_name? (yes/no) [yes]:
 > 

 Do you really want to import islandora_defaults : field.field.media.image.field_original_name? (yes/no) [yes]:
 > 

 Do you really want to import islandora_defaults : field.field.media.file.field_original_name? (yes/no) [yes]:
 > 

 Do you really want to import islandora_defaults : field.field.media.audio.field_original_name? (yes/no) [yes]:
 > 

 Do you really want to import islandora_defaults : core.entity_form_display.media.audio.default? (yes/no) [yes]:
 > 

 Do you really want to import islandora_defaults : core.entity_form_display.media.file.default? (yes/no) [yes]:
 > 

 Do you really want to import islandora_defaults : core.entity_form_display.media.image.default? (yes/no) [yes]:
 > 

 Do you really want to import islandora_defaults : core.entity_form_display.media.video.default? (yes/no) [yes]:
 > 

 Do you really want to import islandora_defaults : core.entity_form_display.node.islandora_object.default? (yes/no) [yes]:
 > 

 Do you really want to import islandora_defaults : core.entity_view_display.media.audio.default? (yes/no) [yes]:
 > 

 Do you really want to import islandora_defaults : core.entity_view_display.media.file.default? (yes/no) [yes]:
 > 

 Do you really want to import islandora_defaults : core.entity_view_display.media.image.default? (yes/no) [yes]:
 > 

 Do you really want to import islandora_defaults : core.entity_view_display.media.video.default? (yes/no) [yes]:
 > 

 Do you really want to import islandora_defaults : core.entity_view_display.node.islandora_object.default? (yes/no) [yes]:
 > 

 Do you really want to import islandora_defaults : rdf.mapping.media.audio? (yes/no) [yes]:
 > 

 Do you really want to import islandora_defaults : rdf.mapping.media.file? (yes/no) [yes]:
 > 

 Do you really want to import islandora_defaults : rdf.mapping.media.image? (yes/no) [yes]:
 > 

 Do you really want to import islandora_defaults : rdf.mapping.media.video? (yes/no) [yes]:
 > 


In FieldConfig.php line 315:
                                                                                           
  Attempt to create a field field_original_name that does not exist on entity type media.  
                                                                                           

[seth-shaw-unlv]

@mjordan, you need to drush fim islandora_core_feature. That is where the config is.

[seth-shaw-unlv]

[vagrant@claw islandora_defaults]$ drush fim -y islandora_core_feature

 // Do you really want to import islandora_core_feature : field.storage.media.field_original_name?: yes.                

[vagrant@claw islandora_defaults]$ drush fim -y islandora_defaults

 // Do you really want to import islandora_defaults : field.field.media.video.field_original_name?: yes.                

 // Do you really want to import islandora_defaults : field.field.media.image.field_original_name?: yes.                

 // Do you really want to import islandora_defaults : field.field.media.file.field_original_name?: yes.                 

 // Do you really want to import islandora_defaults : field.field.media.audio.field_original_name?: yes.                

 // Do you really want to import islandora_defaults : core.entity_form_display.media.audio.default?: yes.               

 // Do you really want to import islandora_defaults : core.entity_form_display.media.file.default?: yes.                

 // Do you really want to import islandora_defaults : core.entity_form_display.media.image.default?: yes.               

 // Do you really want to import islandora_defaults : core.entity_form_display.media.video.default?: yes.               

 // Do you really want to import islandora_defaults : core.entity_view_display.media.audio.default?: yes.               

 // Do you really want to import islandora_defaults : core.entity_view_display.media.file.default?: yes.                

 // Do you really want to import islandora_defaults : core.entity_view_display.media.image.default?: yes.               

 // Do you really want to import islandora_defaults : core.entity_view_display.media.video.default?: yes.               

 // Do you really want to import islandora_defaults : rdf.mapping.media.audio?: yes.                                    

 // Do you really want to import islandora_defaults : rdf.mapping.media.file?: yes.                                     

 // Do you really want to import islandora_defaults : rdf.mapping.media.image?: yes.                                    

 // Do you really want to import islandora_defaults : rdf.mapping.media.video?: yes.                                    

[vagrant@claw islandora_defaults]$ 

[mjordan]

Sorry, will try again this evening.

[mjordan]

Works as advertised. However, the Original Name field is of type "Text (plain, long)", with 5 rows. Shouldn't it be "Text (plain)"?

[seth-shaw-unlv]

Generally the 255 characters provided by a string field is enough to support a file name based on the max limit for modern filesystems. However, users may also want to include original path information as part of the field's value, so I opted for string_long which can support several thousand characters.

[mjordan]

Fair enough!

[mjordan]

@Islandora/8-x-committers I've tested this and am ready to merge, but does anyone feel like we need to autopopulate the field at this point? Or is it OK if that's a subsequent PR?

[dannylamb]

@mjordan Merging is fine by me 🙇‍♂️ We can keep Islandora/documentation#1276 open for someone to reference when they follow up.

[mjordan]

Tested with Islandora/islandora_defaults#13, works as intended.