DDST-312: Addressing a warning when search_endpoint option isn't set
#1035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adam-vessey
changed the title
search_endpoint option isn't setsearch_endpoint option isn't set
adam-vessey
reviewed
Jul 10, 2024
| @@ -494,17 +494,20 @@ protected function defineOptions() { | |||
| */ | |||
| protected function addSearchEndpoint(array &$json, array $url_components) { | |||
| $url_base = $this->getRequest()->getSchemeAndHttpHost(); | |||
| $hocr_search_path = $this->options['search_endpoint']; | |||
| $hocr_search_url = $url_base . '/' . ltrim($hocr_search_path, '/'); | |||
| $hocr_search_path = $this->options['search_endpoint'] ?? null; | |||
There was a problem hiding this comment.
Looks like this introduced a little coding standards thing: #1040
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue: N/A
What does this Pull Request do?
Adds a null coalescing operator when attempting to read the
search_endpointoption and a null-check in the event that it hasn't been set, and handle the following warning:What's new?
Adds a null coalescing operator when attempting to read the
search_endpointvariable. Then performs a null-check before executing operations with that value that may not exist.(i.e. Regeneration activity, etc.)? No.
How should this be tested?
Load a page where the
addSearchEndpointfunction is called, but thesearch_endpointoption is not set.Interested parties
@Islandora/committers