Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added basic tests to image service #65

Closed
wants to merge 1 commit into from
Closed

added basic tests to image service #65

wants to merge 1 commit into from

Conversation

acoburn
Copy link
Contributor

@acoburn acoburn commented Oct 9, 2015

Supersedes #58

@DiegoPino
Copy link
Contributor

hey @acoburn , awesome, looks very good to me 👍

@ruebot
Copy link
Member

ruebot commented Nov 5, 2015

@acoburn I can't remember. Is this PR dependant on the other PRs that went into the dev branch? ...I'd say the same for #47 and #48 too.

@acoburn
Copy link
Contributor Author

acoburn commented Nov 6, 2015

@ruebot I am going to close #47 and #48 for now. I may reopen them later, but I'd like a testing framework in place first. This PR definitely depends on #46 which is in the -dev branch. Is that what you're asking?

This was referenced Nov 6, 2015
@ruebot
Copy link
Member

ruebot commented Nov 6, 2015

@acoburn that's it. So, we just have to sort out the issues with jetty9 and multipart in #83, and then we should be good to proceed again here, and #47 & #48. So close 😄 -- maybe this is something we can resolve by then end of the sprint.

@ruebot ruebot mentioned this pull request Nov 20, 2015
@whikloj
Copy link
Member

whikloj commented Nov 30, 2015

@acoburn with #83 and #119 complete, do you want to close or update this PR? If you are busy (as I am sure you are), I can try to rebase it.

@ruebot
Copy link
Member

ruebot commented Nov 30, 2015

@whikloj thanks! I nearly forgot about this one 😓

@acoburn
Copy link
Contributor Author

acoburn commented Nov 30, 2015

@whikloj thanks for the reminder. Should this PR target the -dev branch or the main 7.x-2.x branch?

@whikloj
Copy link
Member

whikloj commented Nov 30, 2015

@acoburn I would say the main branch.
I believe we are deleting the -dev branch, am I correct @ruebot @daniel-dgi @DiegoPino??

@ruebot
Copy link
Member

ruebot commented Nov 30, 2015

@acoburn the main 7.x-2.x branch. ...which means we should get rid of that dev branch. @whikloj, @DiegoPino, @daniel-dgi did y'all talk about that on last week's call?

@ruebot
Copy link
Member

ruebot commented Nov 30, 2015

@whikloj JINX?

@acoburn
Copy link
Contributor Author

acoburn commented Nov 30, 2015

@whikloj @ruebot thanks! I'll need to close this and re-open the PR against the other branch then.

@acoburn acoburn closed this Nov 30, 2015
@ruebot
Copy link
Member

ruebot commented Nov 30, 2015

thanks @acoburn!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants