Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mention of contexts and openseadragon. #2284

Merged
merged 2 commits into from
Feb 14, 2024
Merged

Conversation

rosiel
Copy link
Member

@rosiel rosiel commented Feb 12, 2024

Purpose / why

#2281

What changes were made?

Update description of contexts from a openseadragon-only context (little-c), to reflect the new mirador-first-but-openseadragon-optional context.

Verification

Is it accurate?

Interested Parties

@kayakr

  • @Islandora/documentation
  • @Islandora/committers

Checklist

Pull-request Reviewer

Pull-request reviewer should ensure the following:

Person Merging

The person merging should ensure the following:

  • Does mkdocs still build successfully? (This is indicated by TravisCI passing. To test locally, and see warnings, see How To Build Documentation.)
  • If pages are renamed or removed, have all internal links to those pages been fixed?
  • If pages are added, have they been linked to or placed in the menu?
  • Did the PR receive at least one approval from a committer, and all issues raised have been addressed?

Copy link

github-actions bot commented Feb 12, 2024

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-02-14 18:48 UTC

@aOelschlager aOelschlager self-requested a review February 14, 2024 18:06
Copy link
Contributor

@aOelschlager aOelschlager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@aOelschlager aOelschlager merged commit 697ce9c into main Feb 14, 2024
1 check passed
@joecorall joecorall deleted the rosiel-openseadragon branch February 15, 2024 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants