Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: updating_drupal.md improvements #2241

Merged
merged 2 commits into from
Jun 15, 2023

Conversation

ysuarez
Copy link
Contributor

@ysuarez ysuarez commented Jun 12, 2023

Purpose / why

I wanted to update the composer syntax for updating Drupal, since the current code seemed to be in the style of the older Islandora 8 before the release of Islandora 2.

This is tied to this issue I had created a while ago...
[DOCS] The "Updating Drupal" section may need updating for Drupal 9

What changes were made?

I simplified the composer update syntax, and still kept the older Islandora 8 syntax. I also added a link to the existing page that explains how to update Drupal for ISLE users.

Verification

Those that are familiar with Drupal updates with composer should review my syntax.

Interested Parties

  • @Islandora/documentation
  • @Islandora/committers

Checklist

Pull-request Reviewer

Pull-request reviewer should ensure the following:

Person Merging

The person merging should ensure the following:

  • Does mkdocs still build successfully? (This is indicated by TravisCI passing. To test locally, and see warnings, see How To Build Documentation.)
  • If pages are renamed or removed, have all internal links to those pages been fixed?
  • If pages are added, have they been linked to or placed in the menu?
  • Did the PR receive at least one approval from a committer, and all issues raised have been addressed?

@ysuarez ysuarez changed the title Docs: drupal update improvements Docs: updating_drupal.md improvements Jun 14, 2023
@rosiel rosiel self-requested a review June 14, 2023 17:31
@rosiel rosiel merged commit 325b09c into Islandora:main Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants