Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document transcripts. #2105

Merged
merged 6 commits into from
Nov 24, 2022
Merged

Document transcripts. #2105

merged 6 commits into from
Nov 24, 2022

Conversation

rosiel
Copy link
Member

@rosiel rosiel commented May 16, 2022

Purpose / why

Document how transcripts work in Islandora.

What changes were made?

A page was added outlining how transcripts can be used.

Verification

The claims made can be validated with an installation of islandora defaults

Interested Parties

@Islandora/documentation

Checklist

Pull-request Reviewer

Pull-request reviewer should ensure the following:

Person Merging

The person merging should ensure the following:

  • Does mkdocs still build successfully? (This is indicated by TravisCI passing. To test locally, and see warnings, see How To Build Documentation.)
  • If pages are renamed or removed, have all internal links to those pages been fixed?
  • If pages are added, have they been linked to or placed in the menu?
  • Did the PR receive at least one approval from a committer, and all issues raised have been addressed?

@inikolaidis
Copy link
Contributor

I attempted to follow these instructions in the sandbox, not realising defaults is not a part of sandbox. An installation with Islandora Defaults is required to go through transcripts steps

@rosiel
Copy link
Member Author

rosiel commented Sep 28, 2022

Thanks for testing! Yes, that is... An issue.

Transcripts should be testable in the sandbox if you add a "media track" type field in the Audio or Video media types.

To be pedantic, Defaults is part of the Sandbox, it's just that the Install Profile clobbers over all Defaults configs with their own. Also as we are getting rid of Defaults soon, it's worth mentioning that transcripts behaviour is part of its successor, the Starter site.

docs/user-documentation/transcripts.md Outdated Show resolved Hide resolved
@rosiel
Copy link
Member Author

rosiel commented Nov 9, 2022

i'll fix the merge conflict.

@kstapelfeldt kstapelfeldt merged commit 9bab170 into Islandora:main Nov 24, 2022
@rosiel rosiel deleted the transcripts branch November 25, 2022 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants