Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLAWdit #37

Merged
merged 8 commits into from
Sep 26, 2019
Merged

CLAWdit #37

merged 8 commits into from
Sep 26, 2019

Conversation

seth-shaw-unlv
Copy link
Contributor

@seth-shaw-unlv seth-shaw-unlv commented Sep 25, 2019

GitHub Issue: Islandora/documentation/issues/1267

Tech Call minutes, item 1.

What does this Pull Request do?

Updates the README to better conform to the standard template.

What's new?

  • Changes a few README links.
  • Added missing sections.

How should this be tested?

Give it a read and compare it to the template.

Additional Notes:

@manez is looking into a module mascot.

Interested parties

@Islandora-CLAW/committers

@manez
Copy link
Member

manez commented Sep 26, 2019

Mascot!

image

Reference 😉

manez
manez previously requested changes Sep 26, 2019
Copy link
Member

@manez manez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The mascot's taking up a lot of real estate. here's a smaller version:

image

@seth-shaw-unlv
Copy link
Contributor Author

I was just going to ask for that! Thanks.

@seth-shaw-unlv seth-shaw-unlv dismissed manez’s stale review September 26, 2019 14:56

Updated the image src link. Thanks!

manez
manez previously approved these changes Sep 26, 2019
@seth-shaw-unlv
Copy link
Contributor Author

seth-shaw-unlv commented Sep 26, 2019

Ack! You approved it @manez and then I made changes. Sorry! I'm done now...

manez
manez previously approved these changes Sep 26, 2019
Copy link
Member

@manez manez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No sweat! I still approve!

@seth-shaw-unlv
Copy link
Contributor Author

Great! Although I presume we still need a @Islandora-CLAW/committers to review/merge it.

@manez
Copy link
Member

manez commented Sep 26, 2019

Indeed. I'm just giving my non-Committer thumbs up 👍

README.md Outdated Show resolved Hide resolved
@dannylamb dannylamb merged commit 2ce8f70 into Islandora:8.x-1.x Sep 26, 2019
@seth-shaw-unlv seth-shaw-unlv deleted the clawdit branch September 26, 2019 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants