-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test a theory. #50
Merged
Merged
Test a theory. #50
Changes from 10 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
ee4b1ba
Test a theory.
ruebot 4d8ffb9
Partially address https://github.com/Islandora-CLAW/CLAW/issues/282
ruebot 8ff59ac
Redo part of transaction test
ruebot e002cf6
Redo part of transaction test... again.
ruebot 618f937
Another experiment
ruebot d91e834
BOOM
ruebot 41eb943
Add links to README
ruebot 8d95e4d
Right covers, and add authors
ruebot ceafed8
facepalm
ruebot 8fe3b44
Add more authors.
ruebot 3f5a408
code review
ruebot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -12,6 +12,7 @@ | |
* @package Islandora | ||
* @author Daniel Lamb <[email protected]> | ||
* @author Nick Ruest <[email protected]> | ||
* @author Diego Pino <[email protected]> | ||
* @license http://www.gnu.org/licenses/gpl-3.0.en.html GPL | ||
* @link http://www.islandora.ca | ||
*/ | ||
|
@@ -293,7 +294,7 @@ public function deleteResource( | |
* Issues a COPY request to Fedora. | ||
* | ||
* @param string $uri Resource URI | ||
* @param array $destination Destination URI | ||
* @param string $destination Destination URI | ||
* @param string $transaction Transaction id | ||
* | ||
* @return string Uri of newly created copy or null if failed | ||
|
@@ -322,7 +323,7 @@ public function copyResource( | |
* Issues a MOVE request to Fedora. | ||
* | ||
* @param string $uri Resource URI | ||
* @param array $destination Destination URI | ||
* @param string $destination Destination URI | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Also, this change should probably be continued to FedoraApi's |
||
* @param string $transaction Transaction id | ||
* | ||
* @return string Uri of moved resource or null if failed | ||
|
@@ -350,7 +351,7 @@ public function moveResource( | |
/** | ||
* Creates a new transaction. | ||
* | ||
* @return string Transaction id or null if failure | ||
* @return null|string Transaction id or null if failure | ||
*/ | ||
public function createTransaction() | ||
{ | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -12,6 +12,8 @@ | |
* @package Islandora | ||
* @author Daniel Lamb <[email protected]> | ||
* @author Nick Ruest <[email protected]> | ||
* @author Jared Whiklo <[email protected]> | ||
* @author Diego Pino <[email protected]> | ||
* @license http://www.gnu.org/licenses/gpl-3.0.en.html GPL | ||
* @link http://www.islandora.ca | ||
*/ | ||
|
@@ -28,6 +30,9 @@ | |
* @category Islandora | ||
* @package Islandora | ||
* @author Daniel Lamb <[email protected]> | ||
* @author Nick Ruest <[email protected]> | ||
* @author Jared Whiklo <[email protected]> | ||
* @author Diego Pino <[email protected]> | ||
* @license http://www.gnu.org/licenses/gpl-3.0.en.html GPL | ||
* @link http://www.islandora.ca | ||
*/ | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -26,6 +26,7 @@ | |
* @category Islandora | ||
* @package Islandora | ||
* @author Daniel Lamb <[email protected]> | ||
* @author Diego Pino <[email protected]> | ||
* @license http://www.gnu.org/licenses/gpl-3.0.en.html GPL | ||
* @link http://www.islandora.ca | ||
*/ | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -24,6 +24,8 @@ | |
* @category Islandora | ||
* @package Islandora | ||
* @author Daniel Lamb <[email protected]> | ||
* @author Nick Ruest <[email protected]> | ||
* @author Diego Pino <[email protected]> | ||
* @license http://www.gnu.org/licenses/gpl-3.0.en.html GPL | ||
* @link http://www.islandora.ca | ||
*/ | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,6 +11,7 @@ | |
* @category Islandora | ||
* @package Islandora | ||
* @author Daniel Lamb <[email protected]> | ||
* @author Nick Ruest <[email protected]> | ||
* @license http://www.gnu.org/licenses/gpl-3.0.en.html GPL | ||
* @link http://www.islandora.ca | ||
*/ | ||
|
@@ -23,6 +24,7 @@ | |
* @category Islandora | ||
* @package Islandora | ||
* @author Daniel Lamb <[email protected]> | ||
* @author Diego Pino <[email protected]> | ||
* @license http://www.gnu.org/licenses/gpl-3.0.en.html GPL | ||
* @link http://www.islandora.ca | ||
*/ | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,6 +11,8 @@ | |
* @category Islandora | ||
* @package Islandora | ||
* @author Daniel Lamb <[email protected]> | ||
* @author Nick Ruest <[email protected]> | ||
* @author Diego Pino <[email protected]> | ||
* @license http://www.gnu.org/licenses/gpl-3.0.en.html GPL | ||
* @link http://www.islandora.ca | ||
*/ | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change should be continued to FedoraApi's
copyResource
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@whikloj pushed a new commit.