Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'The string "claw" was not found' or - COMPLETE DECLAW #1267 #1314 #18

Merged
merged 3 commits into from
Oct 21, 2019
Merged

Conversation

manez
Copy link
Member

@manez manez commented Oct 21, 2019

GitHub Issue: Islandora/documentation#1267 and Islandora/documentation#1314

What does this Pull Request do?

Cleans out the last few traces of CLAW in urls and references, including the last holdout: claw-playbook islandora-playbook

What's new?

Not much! Just some url updates.

How should this be tested?

Preview the files and verify that the links still work.

Additional Notes:

I left the irc reference in CONTRIBUTING.md because it has not officially been deprecated yet, and this keeps CONTRIBUTING.md consistent across the board. It will probably need to be updated again for the irc -> Slack move, but I didn't see any need to hold up the deCLAWing for that.

Interested parties

@whikloj as maintainer

@codecov
Copy link

codecov bot commented Oct 21, 2019

Codecov Report

Merging #18 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##                dev      #18   +/-   ##
=========================================
  Coverage     89.25%   89.25%           
  Complexity      123      123           
=========================================
  Files             6        6           
  Lines           363      363           
  Branches         61       61           
=========================================
  Hits            324      324           
  Misses           19       19           
  Partials         20       20

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 828d078...26886e5. Read the comment docs.

@whikloj
Copy link
Member

whikloj commented Oct 21, 2019

@manez totally not what you did, but we seem to have a duplicate "Development" section in the README.md. Could you remove the second one and then I'll merge this.

@whikloj
Copy link
Member

whikloj commented Oct 21, 2019

Or maybe the first one, the second section has an additional line.

@manez
Copy link
Member Author

manez commented Oct 21, 2019

@whikloj de-duped now

Copy link
Member

@whikloj whikloj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@whikloj whikloj merged commit 19853e7 into Islandora:dev Oct 21, 2019
dannylamb added a commit that referenced this pull request Feb 10, 2020
* Preparing for next development iteration

* Update CONTRIBUTING.md (#15)

* Fix typo: s/contraint/constraint

* Ran Aspell CLI spell checker (#17)

I used an Aspell "word list" based on the "word list" from the ISLE repo found
here...
https://raw.githubusercontent.com/Islandora-Collaboration-Group/ISLE/master/.aspell.en.pws

* Update README for CLAWdit (#16)

* Update README.md

* Update README.md

* Update README.md

Nothing left but the playbook!

* 'The string "claw" was not found' or - COMPLETE DECLAW #1267 #1314 (#18)

* Update CONTRIBUTING.md

* Update README.md

* Update README.md

* Update PULL_REQUEST_TEMPLATE.md (#19)

* Moves maven URL to https (#21)

fixes: Islandora/documentation#1415

* Add a disable switch to the config XML (#20)

Co-authored-by: dannylamb <[email protected]>
Co-authored-by: Melissa Anez <[email protected]>
Co-authored-by: J Hunt <[email protected]>
Co-authored-by: Yamil <[email protected]>
Co-authored-by: B. Seeger <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants