-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Container name #88
Container name #88
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #88 +/- ##
============================================
+ Coverage 94.77% 94.81% +0.03%
+ Complexity 168 167 -1
============================================
Files 9 9
Lines 689 694 +5
============================================
+ Hits 653 658 +5
Misses 36 36
Continue to review full report at Codecov.
|
Had to merge in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
** Please hold on from testing. Will provide more info. **
GitHub Issue: (link)
Part of the work towards: Islandora/documentation#926
What does this Pull Request do?
This PR accepts fedora_end_point as header argument and uses it to create the fedora resource.
Dependency: Islandora/Alpaca#65
Additional Notes on testing:
Backup installed Gemini and Milliner
vagrant@claw:/var/www/html$ sudo cp -R Crayfish/Gemini/ ./
vagrant@claw:/var/www/html$ sudo cp -R Crayfish/Milliner/ ./
Delete Gemini and Milliner folders
vagrant@claw:/var/www/html/Crayfish$ rm -R Gemini
vagrant@claw:/var/www/html/Crayfish$ rm -R Milliner
Get the PR into a folder:
vagrant@claw:/var/www/html$ sudo mkdir CrayfishNew
vagrant@claw:/var/www/html/CrayfishNew$ sudo git clone https://github.com/Islandora/Crayfish
vagrant@claw:/var/www/html/CrayfishNew/Crayfish$ sudo git fetch origin pull/88/head:test
vagrant@claw:/var/www/html/CrayfishNew/Crayfish$ sudo git checkout test
Get the Gemini PR and install
vagrant@claw:/var/www/html/Crayfish$ sudo cp -R ../CrayfishNew/Crayfish/Gemini/ ./
vagrant@claw:/var/www/html/Crayfish/Gemini$ sudo cp /var/www/html/Gemini/syn-settings.xml ./
vagrant@claw:/var/www/html/Crayfish/Gemini/cfg$ sudo cp /var/www/html/Gemini/cfg/config.yaml ./
Testing Gemini:
vagrant@claw:/var/www/html/Crayfish$ sudo cp -R ../CrayfishNew/Crayfish/Milliner/ ./
vagrant@claw:/var/www/html/Crayfish/Milliner$ sudo cp ../../Milliner/syn-settings.xml ./
vagrant@claw:/var/www/html/Crayfish/Milliner/cfg$ sudo cp ../../../Milliner/cfg/config.yaml ./
vagrant@claw:/var/www/html/Crayfish/Milliner/cfg$ sudo cp ../../../Milliner/cfg/config.yaml ./
Replace
/var/www/html/Crayfish/Milliner/vendor/islandora/crayfish-commons
With
Islandora/Crayfish-Commons#36
Assuming we have a container named container_a, which can be created as below:
A gemini post request should return: