Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating build status icon #85

Closed
wants to merge 4 commits into from
Closed

Updating build status icon #85

wants to merge 4 commits into from

Conversation

dannylamb
Copy link
Contributor

Noticed this while working through something else

GitHub Issue: Islandora/documentation#1267

What does this Pull Request do?

Uses the dev branch for travis's build status icon.

How should this be tested?

The icon should say that builds are passing.

Interested parties

@Islandora/8-x-committers

Noticed this while working through something else
@codecov
Copy link

codecov bot commented Oct 29, 2019

Codecov Report

Merging #85 (298e012) into dev (291ebe0) will increase coverage by 2.77%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev      #85      +/-   ##
============================================
+ Coverage     91.87%   94.64%   +2.77%     
+ Complexity      175      160      -15     
============================================
  Files             9        9              
  Lines           726      654      -72     
============================================
- Hits            667      619      -48     
+ Misses           59       35      -24     
Impacted Files Coverage Δ Complexity Δ
Milliner/src/Controller/MillinerController.php 93.65% <0.00%> (-3.38%) 16.00% <0.00%> (-8.00%)
Gemini/src/Controller/GeminiController.php 98.21% <0.00%> (-0.04%) 19.00% <0.00%> (ø%)
Gemini/src/UrlMinter/UrlMinter.php 100.00% <0.00%> (ø) 3.00% <0.00%> (+1.00%)
Homarus/src/Controller/HomarusController.php 100.00% <0.00%> (ø) 12.00% <0.00%> (-1.00%)
Houdini/src/Controller/HoudiniController.php 100.00% <0.00%> (ø) 12.00% <0.00%> (ø%)
Milliner/src/Service/MillinerService.php 99.56% <0.00%> (+9.71%) 49.00% <0.00%> (-7.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44eaba6...ca91578. Read the comment docs.

@whikloj
Copy link
Member

whikloj commented Dec 19, 2019

IMHO this should stick to master as that is the authoritative branch and if we switch it we have to remember to switch it back on release.

We could fix the Gemini phpcs issue on master, or wait until the next release and make sure master is left working there.

@dannylamb
Copy link
Contributor Author

Re-updated to point at main @whikloj

@dannylamb
Copy link
Contributor Author

Looks like this has already been fixed in the Drupal 9 sprint. Closing!

@dannylamb dannylamb closed this Dec 17, 2020
@whikloj whikloj deleted the travis-build-icon branch April 29, 2021 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants