homarus #52
homarus #52
Conversation
Codecov Report
@@ Coverage Diff @@
## master #52 +/- ##
=========================================
Coverage 65.32% 65.32%
Complexity 86 86
=========================================
Files 5 5
Lines 421 421
=========================================
Hits 275 275
Misses 146 146Continue to review full report at Codecov.
|
config.yaml will be created by ansible
There was a problem hiding this comment.
I ran into a few hiccups deploying, but otherwise totally works. Converted an mp4 to an avi no prob, using both Fedora and Drupal uris for videos in the Apix-Ldp-Resource header.
Needs tests, which is making composer check fail. If you spoof it by making an empty tests directory, you get a bunch of phpcs errors that phpcbf could make short work of.
Let's make a separate ticket for tests and just make sure they get done before release. If you can address the coding standards and other issues, I'm happy to pull this in.
|
|
||
| ## Installation | ||
| - Install `ffmpeg`. On Ubuntu, this can be done with `sudo apt-get install ffmpeg`. | ||
| - Copy `/var/www/html/Crayfish/Homarus/cfg/config.default.yml` to `/var/www/html/Crayfish/Homarus/cfg/config.yml` |
There was a problem hiding this comment.
Shuffle these two copy commands under cloning the repository so the files will exist.
Homarus/README.md
Outdated
|
|
||
| ## Configuration | ||
|
|
||
| If your homarus installation is not on your path, then you can configure Homarus to use a specific executable by editing `executable` entry in [config.yaml](./cfg/config.example.yaml). |
There was a problem hiding this comment.
I read that as you can use something other than ffmpeg to do your conversion?
GitHub Issue: (link)
Islandora/documentation#929
What does this Pull Request do?
This PR along with related PRs adds a php micro service that creates video derivatives using ffmpeg.
How should this be tested?
This PR needs to be tested with other related PRs.
Interested parties
Tag (@ mention) interested parties or, if unsure, @Islandora-CLAW/committers