-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chop off charset from mimetype for external content header #131
Conversation
Tested and can confirm the original 400 errors I was getting are gone. But, I have two other errors now.
|
If it helps, here's what's happening in Karaf:
I don't see anything in fcrepo though, and I'm not 100% if this is all related to the original issue you created @whikloj. |
@ruebot Could you check your External Content setup. I'm guessing now that the external requests are working your Fedora is not allowing the hostname. |
@whikloj ah, reading that page again made me catch something;
I didn't have trailing slashes on any of my urls in All good now. Thank you taking care of this PR, and helping me out 🙏 |
i'm not entirely sure why the tests didn't run? |
@elizoller tests didn't run because GH Actions are still looking at |
...and the PR is #130 🤦 |
gotcha, i will test #130 then |
@whikloj i don't see a way to give this a poke to make the tests run, do you? |
Codecov Report
@@ Coverage Diff @@
## 2.x #131 +/- ##
============================================
- Coverage 77.55% 76.74% -0.81%
- Complexity 159 161 +2
============================================
Files 6 6
Lines 655 658 +3
============================================
- Hits 508 505 -3
- Misses 147 153 +6
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the coverage didn't change on the patch for this PR, its only complaining about the coverage on the project as a whole so i think this is still ok to merge. i also gave it a test.
GitHub Issue: Islandora/documentation#1918
What does this Pull Request do?
Checks for a
;
in theContent-type
header and if it exists, then splits and uses the first part.Additionally we we're referencing
$headers
increateMediaVersion
and it was not defined.Also fixed a bad
@covers
statementHow should this be tested?
Create a new object, add some media. Check the Milliner logs for the error message like
Also there is no record for the media in Fedora.
Pull in this PR and try again.
Interested parties
@Islandora/8-x-committers