chop off charset from mimetype for external content header #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested and can confirm the original 400 errors I was getting are gone. But, I have two other errors now. |
|
If it helps, here's what's happening in Karaf: I don't see anything in fcrepo though, and I'm not 100% if this is all related to the original issue you created @whikloj. |
|
@ruebot Could you check your External Content setup. I'm guessing now that the external requests are working your Fedora is not allowing the hostname. |
|
@whikloj ah, reading that page again made me catch something;
I didn't have trailing slashes on any of my urls in All good now. Thank you taking care of this PR, and helping me out 🙏 |
ruebot
approved these changes
Oct 15, 2021
|
i'm not entirely sure why the tests didn't run? |
|
@elizoller tests didn't run because GH Actions are still looking at |
|
...and the PR is #130 🤦 |
|
gotcha, i will test #130 then |
|
@whikloj i don't see a way to give this a poke to make the tests run, do you? |
Codecov Report
@@ Coverage Diff @@
## 2.x #131 +/- ##
============================================
- Coverage 77.55% 76.74% -0.81%
- Complexity 159 161 +2
============================================
Files 6 6
Lines 655 658 +3
============================================
- Hits 508 505 -3
- Misses 147 153 +6
Continue to review full report at Codecov.
|
elizoller
approved these changes
Oct 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue: Islandora/documentation#1918
What does this Pull Request do?
Checks for a
;in theContent-typeheader and if it exists, then splits and uses the first part.Additionally we we're referencing
$headersincreateMediaVersionand it was not defined.Also fixed a bad
@coversstatementHow should this be tested?
Create a new object, add some media. Check the Milliner logs for the error message like
Also there is no record for the media in Fedora.
Pull in this PR and try again.
Interested parties
@Islandora/8-x-committers