Start using semver branches. #129
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 2.x #129 +/- ##
=========================================
Coverage 77.55% 77.55%
Complexity 159 159
=========================================
Files 6 6
Lines 655 655
=========================================
Hits 508 508
Misses 147 147 Continue to review full report at Codecov.
|
|
Let's get a response to Islandora/documentation#1908 during the Tech Call tomorrow before we proceed with this one. |
|
Update from the Committers' call: Updating the lock file to all new versions is probably a good thing to do every once in a while, but should not be merged without actually testing! During the call, @jordandukart suggested a better way with cleaner diffs. I'll close this PR and make a new one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue: Islandora/documentation#1907
What does this Pull Request do?
Milliner, Recast, Hypercube and Homarus use semver in their composer.json files. I regenerated their composer.lock files as well. (though, see Islandora/documentation#1908)
This pull request does NOT touch the composer requirements for Houdini, which still uses the dev-symfony-flex branch of crayfish commons.