Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update code to read pipes to eliminate deadlocks #17

Closed
wants to merge 1 commit into from
Closed

Update code to read pipes to eliminate deadlocks #17

wants to merge 1 commit into from

Conversation

jonathangreen
Copy link
Contributor

GitHub Issue

Possible solution to:
Islandora/documentation#943

What does this Pull Request do?

This does two things:

  1. It refactors our pipe handling code, to eliminate a possible deadlock where the process puts a lot of data out on STDERR while we are reading STDOUT.
  2. Adds some simple tests to the CmdExecuteService class.

How should this be tested?

I wrote this pretty quickly, and didn't do a lot of testing, so it for sure needs some testing.

  1. Test the existing services using CmdExecuteService still work okay when applying this patch.
  2. Test if ffmpeg now runs correctly using CmdExecuteService.

Interested parties

@Natkeeran @dannylamb

@jonathangreen
Copy link
Contributor Author

Travis seems angry, but I don't think its anything from this PR that has drawn its ire.

@jonathangreen
Copy link
Contributor Author

This didn't seem to help, so I'm going to close it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jonathangreen