Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes to release Alpaca #83

Merged
merged 1 commit into from
Jan 12, 2022
Merged

fixes to release Alpaca #83

merged 1 commit into from
Jan 12, 2022

Conversation

whikloj
Copy link
Member

@whikloj whikloj commented Dec 10, 2021

GitHub Issue: n/a

What does this Pull Request do?

Changes the required branch from "master" to "2.x", so you can release from this branch as you can't fast-forward anymore.

An alternate is to set requireBranch = '' which makes it ignore it. That seemed more dangerous than just updating it once a major version.

Also ignores the jenv java version file on my machine.

Additional Notes:

Due to upgrading the Gradle version and changes in its publishing and the weak --dry-run of this plugin, I might have to spend some time getting this to work.

Interested parties

Tag (@ mention) interested parties or, if unsure, @Islandora/8-x-committers

@codecov
Copy link

codecov bot commented Dec 10, 2021

Codecov Report

Merging #83 (240948a) into 2.x (7bf983d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##                2.x      #83   +/-   ##
=========================================
  Coverage     78.07%   78.07%           
  Complexity      143      143           
=========================================
  Files            30       30           
  Lines           561      561           
  Branches         27       27           
=========================================
  Hits            438      438           
  Misses          101      101           
  Partials         22       22           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7bf983d...240948a. Read the comment docs.

@whikloj
Copy link
Member Author

whikloj commented Jan 10, 2022

bump

@alxp
Copy link

alxp commented Jan 12, 2022

This looks good. 👍

@alxp alxp merged commit a581e6a into Islandora:2.x Jan 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants