add a call to a milliner versioning endpoint for media #70
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #70 +/- ##
=========================================
+ Coverage 89.76% 90% +0.23%
Complexity 73 73
=========================================
Files 10 10
Lines 293 300 +7
Branches 1 1
=========================================
+ Hits 263 270 +7
Misses 29 29
Partials 1 1
Continue to review full report at Codecov.
|
|
I'm finally on this. Time to wrestle karaf... |
|
Okay, finally got this going and can verify it works with the Crayfish PR after a smoke test. I'll delve into the code now. |
| .toD( | ||
| getMillinerBaseUrl() + | ||
| "media/${exchangeProperty.sourceField}/version?connectionClose=true" | ||
| ).endChoice(); |
There was a problem hiding this comment.
do you mean because i put 'getMillinerBaseUrl....' on the next line?
i'm pretty sure it was throwing an error about the line being too long.
There was a problem hiding this comment.
I was expecting the ending parenthesis before .endChoice to be aligned with .toD. Maybe that's just me.
No biggie though. It passes codestyle checks so I'm fine pulling in this now.
| "rel":"alternate" | ||
| } | ||
| ], | ||
| "isNewVersion":"true" |
There was a problem hiding this comment.
Ah, shoulda caught this sooner, but "isNewVersion" should be down in the "attachment" section under "content" if we want to follow the schema to the letter of the law. Not the end of the world (thank goodness the AS2 police aren't a thing), but we should probably get in alignment with the ontology. I suppose this would affect node versioning as well. It's probably a lot to address here and now, so I'll make a ticket. There'll have to be work done in the islandora module to get this in the right place.
There was a problem hiding this comment.
ah ok, i was unaware of the schema for this
|
was i too late with my indentation fix? |
|
if you have it i'll take it and merge. i was just erring on the side of moving the code in. 🚀 |
GitHub Issue: (Islandora/documentation#740)
What does this Pull Request do?
Passes the message from Drupal through to Milliner to create versions of Media in Fedora
What's new?
How should this be tested?
http://127.0.0.1:8080/fcrepo/rest/2020-02/file.pdf/fcr:metadata/fcr:versionsAdditional Notes:
This PR depends on a Milliner PR or it will break versioning for nodes (media versioning didn't work before this point). - Islandora/Crayfish#96
Interested parties
Tag @Islandora/8-x-committers