Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge broadcaster and pipeline #38

Merged
merged 4 commits into from
Mar 27, 2017

Conversation

dannylamb
Copy link
Contributor

GitHub Issue: Resolves Islandora/documentation#569

What does this Pull Request do?

Merges the broadcaster and pipeline code to be a single route, where behavior is controlled via a header that gets converted to an ExchangePattern.

What's new?

We're using the routingSlip pattern for both now. Using an exchange pattern of InOnly causes the same message to get passed to each recipient. Processing occurs in parallel. Using the exchange pattern of InOut causes the output of each recipient to get passed to the next, with processing occuring in sequence. In other words, InOut causes each step to 'block', allowing us to control the sequence of steps in a workflow.

If no header is provided for the exchange pattern, the default behaviour is to use InOnly.

How should this be tested?

  • Pull these changes into Alpaca
  • ./gradlew install
  • /opt/karaf/bin/client
  • bundle:list | grep islandora to get the number of the islandora-connector-broadcast bundle
  • bundle:update THAT_NUMBER

Everything should continue to work as expected. That is, go do some CRUD on an entity and the changes should be reflected in the triplestore.

Additional Notes:

Thanks to @Natkeeran for posing the right questions when working through an earlier issue, as that's what prompted this improvement.

Interested parties

@Islandora-CLAW/committers

@codecov
Copy link

codecov bot commented Mar 24, 2017

Codecov Report

Merging #38 into master will increase coverage by 1.18%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #38      +/-   ##
============================================
+ Coverage        70%   71.18%   +1.18%     
  Complexity        3        3              
============================================
  Files             3        2       -1     
  Lines            60       59       -1     
============================================
  Hits             42       42              
+ Misses           18       17       -1
Impacted Files Coverage Δ Complexity Δ
...ra/alpaca/connector/broadcast/BroadcastRouter.java 0% <0%> (ø) 0 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 558ef69...ce684c7. Read the comment docs.

@ruebot
Copy link
Member

ruebot commented Mar 24, 2017

Tested, and looks good.

@ruebot ruebot merged commit 82c487d into Islandora:master Mar 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants