Support reverse proxies + CI integration test #43
Conversation
joecorall
changed the title
| # if you're not behind a reverse proxy, you probably do not need to edit these IPs | ||
| # if you are behind a reverse proxy, most likely you can just replace FRONTEND_IP_1 | ||
| # with the IP address used on your front end // reverse proxy domain | ||
| FRONTEND_IP_1=127.0.0.1/32 |
There was a problem hiding this comment.
Shame I didn't see the changes for this go into build kit, we could have made it into a single variable that was delimited by comma. That way we could support any number of IP's.
There was a problem hiding this comment.
You're welcome to open a new PR to simplify. FWIW I did it this way because the values are used in two places. One comma delimited used in docker compose(traefik), the other is multiple directives in buildkit // nginx directive.
There was a problem hiding this comment.
For the bits on nginx we can iterate on a list using confd, let's not worry about it for now though. If someone wants to use more than 3 ip's in the future we can sort it then.
| type: string | ||
| default: 'heads/main' | ||
| schedule: | ||
| - cron: '15 11 * * *' |
There was a problem hiding this comment.
Why test with cron? Do we expect this to fail without changes to the code base?
There was a problem hiding this comment.
Yeah to catch issues with buildkit+starter that are otherwise never discovered
There was a problem hiding this comment.
Thought being: this is sort of the last mile before someone installs a site, so if some issue does arise between buildkit and starter site this feels like the best place to discover it since it's the place those two repos converge
.envanddocker-compose.ymlto allow this docker compose deployment to be a backend to some other frontend domain that acts as a reverse proxy: 84c3883Depends on Islandora-Devops/isle-buildkit#335 for new sites to be able to utilize this