-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes to allow path to the isle-dc repo to have spaces #237
Changes to allow path to the isle-dc repo to have spaces #237
Conversation
I put the details on the errors I am still getting and what I think are the reasons in issue #235 |
The quickest solution is a warning (I just added it). I've tried a few basic methods for escaping the character [space] but have been unsuccessful. It's likely to only take a bit more time but that's additional time than I currently can't invest. |
@ysuarez Do think that will be good enough for now? |
@DonRichards Yes, I think that warning is good enough for now. If and when when you have time, can you put in here or tell me by Slack what methods you tried that failed so far, so I (or someone else) can use that data to help figure out other ways to try fix the remaining path issues. |
@DonRichards I just tested your changes and the error message was triggered and makes sense.
I would support merging this PR , though I am not an ISLE2 developer and "take it with a grain of salt," or at the very least I would suggest that we just add the part that checks if there are spaces in the path. |
I believe this is limitation with Make per this really old bug report http://savannah.gnu.org/bugs/?712 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me.
This pull request is an attempt to fix issue #235 to allow the path to the isle-dc repo to have spaces without causing errors when using makefile commands.
Regretfully there are still issues with this pull request in the
drupal-public-files-import
target from its use of the SRC makefile variable.To test this run
make demo