Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a difficult usability issue if SOLR cannot be initialized.
Currently, a failure to initialize SOLR results in the container aborting. In my case, the solution required me to disable some conflicting SOLR request handlers via Drupal's UI, in order for Drupal to be able to generate config.zip. But this was impossible to do until I could get the container started. A difficult chicken-and-egg situation which is not easy to recover from.
I think it is better to flag the SOLR error clearly (hence this PR as well as Islandora-Devops/isle-buildkit#182) but allow the container to start so that Drupal is available.
This PR shows some earlier commits on my fork (but no diffs from them) because they were merged. Ugly, but I don't know how to clean this up short of deleting my fork entirely and re-creating. Maybe it's possible to squash when merging?