Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft - Add fix-pdfjs #214

Closed
wants to merge 1 commit into from
Closed

Conversation

DonRichards
Copy link
Member

Running make local isn't downloading the PDF.js library. This action was added to the demo container in the buildkit but is missed in the local build.

This downloads the pdfjs library and sets the permissions in the same manor as the fix-masonry command does.

To test

  1. Run make local
  2. Check that '/var/www/drupal/web/libraries/pdf.js' does not exists
  3. Switch to this pull request
  4. Check that '/var/www/drupal/web/libraries/pdf.js' now exists
  5. Test PDF.js works.

@DonRichards DonRichards added the bug Something isn't working label Jan 25, 2022
@DonRichards
Copy link
Member Author

In community call it was suggested to move this to a composer install and/or the sandbox. There was still some confusion on the final decision.

@DonRichards DonRichards changed the title Add fix-pdfjs Draft - Add fix-pdfjs Feb 8, 2022
@DonRichards DonRichards closed this Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant