-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 174 - Logging #206
Issue 174 - Logging #206
Conversation
Lost some time debugging failing tests on my M1 Macbook, need to upgrade Gradle when the next release is minted to get |
The failing test is caused by an odd |
God that was hard to debug for 88f7aa6 at least now I know how to use This is now ready for review. |
From tech call: is it possible to get some testing instructions? |
Broadly speaking to test, is that it works and logs are generated to standard out. |
Hi @rosiel Great question, apologies for the late reply. Hopefully my response below could be copied to I've made a new PR for this process if you have time to review #212 Happy to help as needed here. @nigelgbanks Feel free to add anything I may have missed. [Edit] I originally posted everything here as a response and realized it should just be a draft doc to work on instead. Sorry for the dump folks. Thanks, |
Tested and this passes as noted here #174 @nigelgbanks Ship it. |
For Issue-174 this removes the use of symlinks and instead appropriately configures the logging for each service using the recommend methods according to their documentation.
There is one notable exception
handle
still uses symlinks to get the services to write tostdout
/stderr
as there is no other method possible in its cases as the logging is hard coded in the application to write to specific files at specific path.