Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump timeout to 360 as a full cross platform rebuild with tests takes… #200

Merged
merged 2 commits into from
Apr 8, 2022

Conversation

nigelgbanks
Copy link
Contributor

… more than 60 minutes now.

Only timeout-minutes has changed the rest is formatting.

@nigelgbanks nigelgbanks requested a review from g7morris March 23, 2022 19:59
@g7morris g7morris added bug Something isn't working help wanted Extra attention is needed release labels Mar 23, 2022
@g7morris g7morris self-assigned this Mar 23, 2022
@g7morris
Copy link
Contributor

Okay I think this passes but I didn't test beyond the site coming up.

@nigelgbanks Would testing ingest of some kind be the real test here?

If so, do you have a sense of what kind of sample object and metadata we'd need?

Anything you can share by way of steps to test or materials (suggested samples) would be ideal.

Cheers!


Reporting results from testing process:

isle-dc

Test Environment

  • OS: MacOS Monterey 12.3 - (Mac Mini 9,1)
  • CPU: 8 cores
  • Mem: 16 GB

Steps taken to test

  • git clone [email protected]:Islandora-Devops/isle-dc.git to local laptop
  • cd isle-dc
  • cp sample.env .env
  • vi / nano .env
    • Changed TAG= to TAG= 034f5beb902654cd495bcb79c4e92b3899512908
  • make demo
  • Navigated to islandora.traefik.me and logged in as test
  • Reviewed site and log reports. No new errors reported.

@g7morris g7morris removed their request for review March 24, 2022 14:21
@g7morris g7morris assigned nigelgbanks and unassigned g7morris Mar 24, 2022
@g7morris g7morris added the question Further information is requested label Mar 24, 2022
@nigelgbanks
Copy link
Contributor Author

Oh there isn't really anything needing testing here this just bumps the max timeout time for Github actions.

@nigelgbanks nigelgbanks merged commit 55ba7ee into main Apr 8, 2022
@nigelgbanks nigelgbanks deleted the bump-timeout branch April 8, 2022 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed question Further information is requested release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants