drupal 8.7 #108
Closed
drupal 8.7 #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whikloj
reviewed
May 24, 2019
| @@ -17,7 +17,7 @@ drupal_composer_dependencies: | |||
| - "islandora/carapace:dev-8.x-1.x" | |||
| - "islandora/openseadragon:dev-8.x-1.x" | |||
| - "islandora/islandora_demo:dev-8.x-1.x" | |||
| drupal_composer_project_package: "islandora/drupal-project:8.6.10" | |||
| drupal_composer_project_package: "islandora/drupal-project:dev-drupal_87" | |||
There was a problem hiding this comment.
@Natkeeran I merged your PR and tagged it, so this can use :8.7 now.
drupal_composer_project_package: "islandora/drupal-project:8.7"
|
I can't get this PR to complete vagrant up. It throws an error at trying to install islandora-demo. I think maybe it's due to this sourcing from an older version of the playbook so I'll try upgrading Drupal from the most recent. |
|
Are we able to close this due to #118? |
|
Yes, this is now replaced by #118 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not merge!
What does this Pull Request do?
admin/config/media/media-settings. More info here: Drupal 8.7 islandora-deprecated/drupal-project#27How should this be tested?
@dannylamb