Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop EOL Python support and update dependencies #109

Merged
merged 13 commits into from
Mar 9, 2023
Merged

Drop EOL Python support and update dependencies #109

merged 13 commits into from
Mar 9, 2023

Conversation

tucked
Copy link
Member

@tucked tucked commented Mar 7, 2023

Full test run to come...

@tucked tucked added this to the 5.0.0 milestone Mar 7, 2023
@tucked tucked mentioned this pull request Mar 7, 2023
Closed
@lfrancke
Copy link
Contributor

lfrancke commented Mar 8, 2023

This is a bit selfish but: Do you think this will be merged/done until next week? We've got an installation next week and it'd be great to know if I need to prepare a custom build or not.

@tucked
Copy link
Member Author

tucked commented Mar 8, 2023

@lfrancke, getting a full test run can take some time (because it involves running against all the supported OneFS versions), so it's kind of hard to say... If it's not ready by the end of the week, though, we can make a pre-release for you! Do you need #105 and #106 too?

@lfrancke
Copy link
Contributor

lfrancke commented Mar 9, 2023

Thank you but don't worry, no extra effort needed for us.
The other two we already did manually, this was mostly for the benefit of others after us
I can try to get them updated next week.

@tucked
Copy link
Member Author

tucked commented Mar 9, 2023

Passing run on 4d0a844: https://gist.github.com/tucked/2c1a6b845db63fc39430b0b5ac4e784d

@tucked tucked marked this pull request as ready for review March 9, 2023 17:36
teajason
teajason approved these changes Mar 9, 2023
View reviewed changes
Copy link
Collaborator

@teajason teajason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, send it!

@tucked tucked merged commit 1978c7e into Isilon:main Mar 9, 2023
@tucked tucked deleted the pyversions branch March 9, 2023 21:15
@tucked tucked added the major This change requires a Major version bump. label Mar 9, 2023
@tucked tucked mentioned this pull request Mar 29, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teajason teajason teajason approved these changes

Assignees
No one assigned
Labels
major This change requires a Major version bump.
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@tucked @lfrancke @teajason