Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't list extension methods multiple times. #836

Merged
merged 2 commits into from
Dec 8, 2023
Merged

Don't list extension methods multiple times. #836

merged 2 commits into from
Dec 8, 2023

Conversation

Simon900225
Copy link
Contributor

This is a copy of the changes from @slozier in ironpython3 IronLanguages/ironpython3#1620
This fixes the same issue in ironpython2 #810

@Simon900225
Copy link
Contributor Author

@dotnet-policy-service agree

slozier
slozier reviewed Dec 7, 2023
View reviewed changes
Copy link
Contributor

@slozier slozier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me. Any reason you need the changes on ExtensionMethodSet? I think the binder was doing the de-duplication.

@Simon900225
Copy link
Contributor Author

Correct. I misread the commits from you and missed that you had reverted that file. I have updated the PR.

@slozier slozier merged commit 31116c9 into IronLanguages:master Dec 8, 2023
1 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slozier slozier slozier left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Simon900225 @slozier