Avoid ToLoverInvariant in string comparisons (CA1862)

IronLanguages · Dec 10, 2023 · bf098a1 · bf098a1
1 parent 7b478c3
commit bf098a1
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/Src/Microsoft.Dynamic/DebugOptions.cs b/Src/Microsoft.Dynamic/DebugOptions.cs
@@ -19,7 +19,7 @@ internal static class DebugOptions {
 
         private static bool ReadOption(string name) {
             string envVar = ReadString(name);
-            return envVar != null && envVar.ToLowerInvariant() == "true";
+            return "true".Equals(envVar, StringComparison.InvariantCultureIgnoreCase);
         }
 
         [System.Diagnostics.CodeAnalysis.SuppressMessage("Microsoft.Usage", "CA1801:ReviewUnusedParameters", MessageId = "name")]

diff --git a/Src/Microsoft.Dynamic/Generation/AssemblyGen.cs b/Src/Microsoft.Dynamic/Generation/AssemblyGen.cs
@@ -283,7 +283,8 @@ private static void CopyDirectory(string to, string from) {
                 string toFile = Path.Combine(to, fi.Name);
                 FileInfo toInfo = new FileInfo(toFile);
 
-                if (fi.Extension.ToLowerInvariant() == ".dll" || fi.Extension.ToLowerInvariant() == ".exe") {
+                if (fi.Extension.Equals(".dll", StringComparison.InvariantCultureIgnoreCase)
+                    || fi.Extension.Equals(".exe", StringComparison.InvariantCultureIgnoreCase)) {
                     if (!File.Exists(toFile) || toInfo.CreationTime != fi.CreationTime) {
                         try {
                             File.Copy(filename, toFile, true);