Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ed25519 to pre1 #98

Merged
merged 5 commits into from
Dec 10, 2019
Merged

Fix ed25519 to pre1 #98

merged 5 commits into from
Dec 10, 2019

Conversation

coltfred
Copy link
Member

@coltfred coltfred commented Dec 10, 2019 •
edited
Loading

  • We weren't properly pinning to pre1, we should be because pre3 is on rand 0.7
  • Only changes to changelog are the 0.9.1 section, but I fixed the formatting for the rest of the CHANGELOG.

clintfred
clintfred approved these changes Dec 10, 2019
View reviewed changes
Copy link
Contributor

@clintfred clintfred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@clintfred
Copy link
Contributor

Maybe there are suddenly formatting issues?

@coltfred
Copy link
Member Author

It's because I went to rust 1.39. I'll revert that change in .travis.yml and merge.

@coltfred coltfred merged commit 2348d97 into master Dec 10, 2019
@coltfred coltfred deleted the fix-pre1 branch December 10, 2019 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giarc3 giarc3 giarc3 approved these changes

@clintfred clintfred clintfred approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@coltfred @clintfred @giarc3