Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Add/Sub for PrivateKey of Monty256/480 and internal #87

Merged
merged 2 commits into from
Aug 19, 2019
Merged

Added Add/Sub for PrivateKey of Monty256/480 and internal #87

merged 2 commits into from
Aug 19, 2019

Conversation

giarc3
Copy link
Member

@giarc3 giarc3 commented Aug 15, 2019

No description provided.

@giarc3 giarc3 requested review from coltfred and clintfred August 15, 2019 17:12
coltfred
coltfred approved these changes Aug 15, 2019
View reviewed changes
Copy link
Member

@coltfred coltfred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple suggestions, other than that it looks good.

src/api_480.rs Outdated Show resolved Hide resolved
src/api.rs Outdated Show resolved Hide resolved
clintfred
clintfred approved these changes Aug 15, 2019
View reviewed changes
Copy link
Contributor

@clintfred clintfred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@giarc3 giarc3 merged commit ede2339 into master Aug 19, 2019
@giarc3 giarc3 deleted the 86-private-key-add-sub branch August 20, 2019 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clintfred clintfred clintfred approved these changes

@ernieturner ernieturner ernieturner approved these changes

@coltfred coltfred coltfred approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@giarc3 @coltfred @ernieturner @clintfred