[#78] Thread safe API #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #78
Like #77 except not just a PoC. Care was taken to only hold Mutex a short amount of time. Because of the
RandomBytesGenabstraction I was able to push the mutability all the way into there, leaving most of the rest of the code untouched. This wasn't immediately obvious, but seems cleaner than alternatives. The only downside is getting a bunch of random numbers in a row will go through a lot of lock/unlock cycles. I'll be interested to see if that shows up in the benchmarks at all, but I'm guessing it won't.Changelog
Recryptamong threads possible.