#80 Add features to let WASM use a 32bit backend for ed25519. Also re-enables CC on clear_on_drop #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
July 16, 2019 13:02
…e-enables CC on clear_on_drop
coltfred
approved these changes
Jul 16, 2019
clintfred
approved these changes
Jul 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rust's dependency feature management isn't in a great place. The goal here was to allow WASM builds to use the ed25519 u32 backend and then use the u64 backend for every other build type. In order to do that we have to disable the u64 for everything and then manually re-enable it using the feature flags. Otherwise ed25519 gets built with both flags which causes a bunch of compile errors for duplicate constants. Relevant issue: dalek-cryptography/curve25519-dalek#264
This ideally would be solved by using the architecture-detection flags (i.e.
target.'cfg(target_env = "wasm32")'.dependencies) but that doesn't seem to work as expected either.