Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

480-bit API support #35

Merged
merged 21 commits into from
Jan 10, 2019
Merged

480-bit API support #35

merged 21 commits into from
Jan 10, 2019

Conversation

clintfred
Copy link
Contributor

@clintfred clintfred commented Jan 7, 2019 •
edited
Loading

A first pass at a 480-bit API.

The API appears to function, but there is lots of duplicated code with the 256-bit API.

I suggest this prior to addressing any way of de-duplicating the two APIs. We can address the duplication via macros, parameterizing the API on the Fp type, or some combination of the two.

TODO

  • - 480-bit benchmarks

@clintfred
WIP: progress toward Fp480 API
f556de9
@clintfred
WIP: api_480 compiles. It certainly does not work, but it compiles!
94843ae
@clintfred
WIP: internal PublicKey and Hashable60
2b21250
@clintfred
WIP
7da2dd2 
* defined real Fr480
* fixed up some tests
* ran `cargo fmt`
@clintfred
WIP Fp480
a0d3641 
* fixed or removed remaining broken 480 tests
* defined new curve points for 480
* defined frobineous factors for 480
@clintfred
WIP Fp480
5ee762f 
* Fp2 and Fp12 property test for 480
* ExtensionField for 480
@clintfred
WIP Fp480
6eda302 
* 480 bit pairing seems to work!
@clintfred
WIP Fp480
d58210b 
* Fr480 tests pass now
@clintfred
First pass at API based on Fp480 - all tests pass
df6c724
@clintfred
test cleanup
ab3d4da
@clintfred
remove duplication of TwistedHPoint BytesDecoder
35935f3
@clintfred
remove unnecessary TwistedHPoint impls
ad8703a
@clintfred
moved ApiErr into api_common
4e0a1b1
@clintfred
added 480 tests to HomogeneousPoint
d6f2a0d
@clintfred
added 480 bit benches
161c407
@clintfred
name 480-bit API Api480 and clean up some TODOs
5202981
@clintfred
macro'd homogeneouspoint proptest to reduce duplication
a3465cf
@clintfred
removed proptest duplication
a582cd0
@clintfred clintfred changed the title [WIP] 480-bit API support 480-bit API support Jan 8, 2019
coltfred
coltfred approved these changes Jan 10, 2019
View reviewed changes
Copy link
Member

@coltfred coltfred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit sad about the amount of duplication, but until we can abstract over array sizes I'm not sure I have a better solution. Thanks for doing that.

@clintfred clintfred merged commit 3db6ac0 into master Jan 10, 2019
@clintfred clintfred deleted the fp480 branch January 10, 2019 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coltfred coltfred coltfred approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@clintfred @coltfred