Consume gridiron 0.4 #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BobWall23
approved these changes
Dec 7, 2018
coltfred
requested changes
Dec 10, 2018
src/api.rs
Outdated
| y * x | ||
| } | ||
| } | ||
| // ///Duplicated here for the generate plaintext test |
src/api.rs
Outdated
| let rth_pow = pow_for_square(fp12, curve_order); | ||
| assert_eq!(rth_pow, Fp12Elem::one()); | ||
| } | ||
| // #[test] |
There was a problem hiding this comment.
Added a comment about rth roots for plaintext to gen_plaintext
| /// | ||
| /// Arguments: | ||
| /// `hex_str` - need to be 63 or 64 bytes. Do not include a leading '0x' | ||
| pub fn fp256_unsafe_from(hex_str: &str) -> fp_256::Fp256 { |
There was a problem hiding this comment.
Should we call this fp256_unsafe_from_hex?
There was a problem hiding this comment.
I think the param name hex_str is a good enough hint.
* renamed NonAdjacentForm to BitRepr
coltfred
approved these changes
Dec 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brings in the gridiron 0.4 and it's 31-bit (constant time!) implementations.
There are no changes to the public interface and bulk of the changes were switching over to hex for constants and test values from limbs.
Other changes
TODO