Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use try_from to avoid having to import Signature #163

Merged
merged 3 commits into from
Nov 29, 2021
Merged

Use try_from to avoid having to import Signature #163

merged 3 commits into from
Nov 29, 2021

Conversation

clintfred
Copy link
Contributor

@clintfred clintfred commented Nov 29, 2021 •
edited
Loading

Removes an unnecessary use statement and instead uses the TryFrom implementation to create a signature from bytes. The use statement was reintroduced to fix compilation errors for some combinations of dependencies introduced in v0.13.0, but the TryFrom approach has the same effect with no compiler warning.

giarc3
giarc3 approved these changes Nov 29, 2021
View reviewed changes
Copy link
Member

@giarc3 giarc3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to make sure we add a changelog entry before releasing

@clintfred clintfred merged commit 021b199 into main Nov 29, 2021
@clintfred clintfred deleted the signature-tryfrom branch November 29, 2021 23:12
clintfred added a commit that referenced this pull request Nov 29, 2021
@clintfred
0.13.1 (2021-11-29)
e9f4cf9 
Public API changes
None

Notable internal changes
[[#163]](#163) Fix compilation error for certain combinations of transitive dependencies related to ed25519-dalek-fiat
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giarc3 giarc3 giarc3 approved these changes

@BobWall23 BobWall23 BobWall23 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@clintfred @BobWall23 @giarc3