Add constant time EQ for structs #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For data types that contain private info (PrivateKey, Plaintext, DerivedSymmetricKey, and SigningKeypair), implement a constant time PartialEq, and remove the Revealed wrapper we were using around these types when comparison was needed.
coltfred
requested changes
Jan 28, 2020
src/api.rs
Outdated
| impl PartialEq for DerivedSymmetricKey { | ||
| fn eq(&self, other: &DerivedSymmetricKey) -> bool { | ||
| let byte_pairs = self.bytes.iter().zip(other.bytes.iter()); | ||
| return byte_pairs.fold(0, |acc, (next_a, next_b)| acc | (next_a ^ next_b)) == 0; |
There was a problem hiding this comment.
removing the ; and the return would be more consistent with our style.
src/api.rs
Outdated
| impl PartialEq for Plaintext { | ||
| fn eq(&self, other: &Plaintext) -> bool { | ||
| self.bytes[..] == other.bytes[..] && self._internal_fp12 == other._internal_fp12 | ||
| let byte_pairs = self.bytes.iter().zip(other.bytes.iter()); | ||
| return byte_pairs.fold(0, |acc, (next_a, next_b)| acc | (next_a ^ next_b)) == 0; |
There was a problem hiding this comment.
removing the ; and the return would be more consistent with our style.
src/api.rs
Outdated
| impl PartialEq for PrivateKey { | ||
| fn eq(&self, other: &PrivateKey) -> bool { | ||
| let byte_pairs = self.bytes.iter().zip(other.bytes.iter()); | ||
| return byte_pairs.fold(0, |acc, (next_a, next_b)| acc | (next_a ^ next_b)) == 0; |
There was a problem hiding this comment.
removing the ; and the return would be more consistent with our style.
src/api_480.rs
Outdated
| impl PartialEq for DerivedSymmetricKey { | ||
| fn eq(&self, other: &DerivedSymmetricKey) -> bool { | ||
| let byte_pairs = self.bytes.iter().zip(other.bytes.iter()); | ||
| return byte_pairs.fold(0, |acc, (next_a, next_b)| acc | (next_a ^ next_b)) == 0; |
There was a problem hiding this comment.
removing the ; and the return would be more consistent with our style.
coltfred
approved these changes
Jan 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For data types that contain private info (PrivateKey, Plaintext,
DerivedSymmetricKey, and SigningKeypair), implement a constant time
PartialEq, and remove the Revealed wrapper we were using around these
types when comparison was needed.