[#14]

* filter out benchmark changes < 2% * return sample size to 20
IronCoreLabs · Oct 18, 2018 · c5bb1fd · c5bb1fd
1 parent 7f48da6
commit c5bb1fd
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/.travis_scripts/cmp-bench.sh b/.travis_scripts/cmp-bench.sh
@@ -42,5 +42,6 @@ if [ "${TRAVIS_PULL_REQUEST_BRANCH:-$TRAVIS_BRANCH}" != "master" ]; then
     # Bench the current commit that was pushed
     git checkout -f "${TRAVIS_PULL_REQUEST_BRANCH:-$TRAVIS_BRANCH}"
     cargo bench -- --save-baseline current-benchmark
-    critcmp master-benchmark current-benchmark
+    # compare the before/after results; filter out anything less than 2% change
+    critcmp master-benchmark current-benchmark -t 2
 fi
diff --git a/benches/api_benchmark.rs b/benches/api_benchmark.rs
@@ -293,7 +293,7 @@ fn criterion_benchmark(c: &mut Criterion) {
 
 criterion_group! {
     name = benches;
-    config = Criterion::default().sample_size(5); //TODO temp change for faster testing, change back to 20
+    config = Criterion::default().sample_size(20);
     targets = criterion_benchmark
 }
 criterion_main!(benches);