Upgrade all dependencies #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remaining tests manually verified.
Single test failing with a logical difference, trying to figure out how it's related to the migration.
|
The final breaking unit test is due to a regression/unintentional breaking change in protobufjs. I'll have to make a logic change to work around that bug. |
All unit tests are passing now. I fixed the mocking by making it a real constant and mocking the import in the test, but @craig pointed out fixing `beforeAll` to `beforeEach` and leaving it a function would've worked too. Since it was only a function _for_ tests, I like changing the tests so it works with it as a real constant more.
giarc3
approved these changes
Aug 11, 2022
But I can really test because this is sloppy and leaves resources all over that eventually make me unable to create new threads.
coltfred
approved these changes
Aug 12, 2022
BobWall23
approved these changes
Aug 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All the dependencies seem to work (verified the failing tests manually in the app). All integration tests are also fixed up and passing (no logic changes needed there, just changes from migrating the integration test runner).
nightwatch-html-report.tar.gz