Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lossless compression #466

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

lossless compression #466

wants to merge 2 commits into from

Conversation

Awqre
Copy link

@Awqre Awqre commented Nov 5, 2024

Lossless PNG compression, packed with optidash icopack

@Iridium-IO
Copy link
Member

You must be joking

@Awqre
Copy link
Author

Awqre commented Nov 17, 2024

You must be joking

Surely the compression based application is not complaining about compression

@Iridium-IO
Copy link
Member

You must be joking

Surely the compression based application is not complaining about compression

Surely you didn't think a PR compressing a 5KB icon was worth it

@Awqre
Copy link
Author

Awqre commented Nov 17, 2024

Dont quite understand the toxicity, took me like 30 seconds to do this for an application I use and appreciate, 2kb across thousands of downloads adds up whether you care or not. Feel free to reject it, approve it or keep being an ass, up to you.

@Iridium-IO
Copy link
Member

Dont quite understand the toxicity, took me like 30 seconds to do this for an application I use and appreciate, 2kb across thousands of downloads adds up whether you care or not. Feel free to reject it, approve it or keep being an ass, up to you.

Fair shout, sorry. It's just most minor PRs like that across github are usually done by bot accounts trying to build credibility (in order to sneak malware into another project later on down the line) or people trying to pad resumes/commit graphs for competitions. There used to be a popular challenge a few years ago that rewarded people for contributing to open source projects and all it did was lead to projects being spammed with small pull requests that didn't really contribute much.

I assumed you fit into one of the above categories. Sorry for being an ass!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants