Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: cjs to load normalize-url #58

Merged
merged 2 commits into from
Aug 30, 2022
Merged

fix: cjs to load normalize-url #58

merged 2 commits into from
Aug 30, 2022

Conversation

privatenumber
Copy link
Contributor

@privatenumber privatenumber commented Aug 3, 2022 •
edited
Loading

Problem

Closes #57

Changes

Remove normalize-url from dependencies, which tells pkgroll to externalize the dependency. Now normalize-url is bundled in.

@themightychris themightychris mentioned this pull request Aug 3, 2022
Closed
@scarrupt scarrupt mentioned this pull request Aug 29, 2022
Merged
@IonicaBizau IonicaBizau mentioned this pull request Aug 30, 2022
Merged
@IonicaBizau IonicaBizau merged commit d1a4395 into IonicaBizau:master Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CommonJS distribution can't import normalize-url
2 participants
@privatenumber @IonicaBizau