Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git-url-parse 12.0.0 #138

Merged
merged 3 commits into from
Jun 27, 2022
Merged

git-url-parse 12.0.0 #138

merged 3 commits into from
Jun 27, 2022

Conversation

IonicaBizau
Copy link
Owner

git-url-parse 12.0.0

This is a major release fixing several issues and improving the security of the project.

Breaking changes

  • VSTS SSH URLs may give unexpected results — I left a TODO in the tests to remind us to fix it.
  • For shorthand urls use the href property instead of pathname.
  • The user and password properties are now parsed separately.

For other potential breaking changes, you may want to check out the release of git-up.

Issues Fixed

If you have any suggestions and questions let me know. 😊

@IonicaBizau IonicaBizau merged commit 6c0ca07 into master Jun 27, 2022
@IonicaBizau IonicaBizau deleted the new-version branch June 27, 2022 13:11
@lianghx-319
Copy link

This release still depends on normalize-url@^6.1.0, which is the version not support Safari. Maybe parse-url should update it's dependence to normalize-url@^7.

The code below make website crash in safari.
image

https://github.com/sindresorhus/normalize-url/blob/437bf1773993bc19b82218050bbfa76f98a014f9/index.js#L128

@lianghx-319 lianghx-319 mentioned this pull request Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants